[ModuleInterface] AliasModuleNames workaround support for indirect dependencies and missing imports #62073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
…orkaround If there's a reference in API to a module that's not imported, the import is inserted automatically in the swiftinterface. This ensures the inserted import is correctly aliased in AliasModuleNames mode.
xymus
force-pushed
the
module-alias-disambiguate-more
branch
from
e74b1ca to
f14a8eb
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
tshortli
approved these changes
Nov 16, 2022
| struct CType {}; | ||
|
|
||
| //--- ExportedLib.swift | ||
|
|
||
| public struct RexportedStruct {} |
There was a problem hiding this comment.
Typo Rexported -> Reexported
There was a problem hiding this comment.
Good catch! I went with Exported to keep in line with the module name.
…irectly In AliasModuleNames, avoid wrongfully printing aliased names for modules that were not aliased. This can happen in the case of modules indirectly imported via a reexport. rdar://102262019
xymus
force-pushed
the
module-alias-disambiguate-more
branch
from
f14a8eb to
7ae02c0
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
were not aliased, just use the real name in that case. This can happen in the case of modules indirectly
imported via a reexport.
import is inserted automatically in the swiftinterface. This PR ensures the
inserted import is correctly aliased in AliasModuleNames mode.
rdar://102262019