Skip to content

[Sema] printConstExprValue should consider negative signal when print number literals #62122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

LucianoPAlmeida
Copy link
Contributor

@LucianoPAlmeida LucianoPAlmeida commented Nov 15, 2022

Method that print number literal(integer and floating point literals) as string value should consider negative numbers as well, otherwise string representation of expression value is incorrect.

Resolves: #62117
Resolves: rdar://102171833

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please test

@xedin
Copy link
Contributor

xedin commented Nov 15, 2022

Thank you!

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please test MacOS Platform

1 similar comment
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please test MacOS Platform

@xedin xedin merged commit 70072a0 into swiftlang:main Nov 16, 2022
@LucianoPAlmeida LucianoPAlmeida deleted the fix-literal-dictionary-int branch January 14, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive duplicate entry warning in literal dictionary
2 participants