Skip to content

Deprecate Application-Specific Main Entrypoint Attributes #62151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/swift/AST/DiagnosticsSema.def
Original file line number Diff line number Diff line change
Expand Up @@ -3601,6 +3601,11 @@ ERROR(attr_ApplicationMain_with_script,none,
"%" SELECT_APPLICATION_MAIN "0 attribute cannot be used in a module that contains "
"top-level code",
(unsigned))
ERROR(attr_ApplicationMain_deprecated,none,
"%" SELECT_APPLICATION_MAIN "0 is deprecated",
(unsigned))
NOTE(attr_ApplicationMain_deprecated_use_attr_main,none,
"use @main instead", ())

NOTE(attr_ApplicationMain_parse_as_library,none,
"pass '-parse-as-library' to compiler invocation if this is intentional",
Expand Down
10 changes: 10 additions & 0 deletions lib/Sema/TypeCheckAttr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2340,6 +2340,16 @@ void AttributeChecker::checkApplicationMainAttribute(DeclAttribute *attr,
attr->setInvalid();
}

diagnose(attr->getLocation(),
diag::attr_ApplicationMain_deprecated,
applicationMainKind)
.warnUntilSwiftVersion(6);

diagnose(attr->getLocation(),
diag::attr_ApplicationMain_deprecated_use_attr_main)
.fixItReplace(attr->getRange(), "@main");


if (attr->isInvalid())
return;

Expand Down
5 changes: 3 additions & 2 deletions test/TBD/objc-entry-point.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
import AppKit

// Globals in non-script mode files that still have entry points
// (via NSApplicationMain) _do_ have lazy initializers. Ensure the symbols are
// (via `@NSApplicationMain`) _do_ have lazy initializers. Ensure the symbols are
// present in the TBD.
let globalConstantWithLazyInitializer: String = "hello, world"

@NSApplicationMain
@NSApplicationMain // expected-warning {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-1 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, NSApplicationDelegate {
}
3 changes: 2 additions & 1 deletion test/attr/ApplicationMain/attr_NSApplicationMain.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import AppKit

@NSApplicationMain
@NSApplicationMain // expected-warning {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-1 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, NSApplicationDelegate {
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import AppKit

class DelegateBase : NSObject, NSApplicationDelegate { }

@NSApplicationMain
@NSApplicationMain // expected-warning {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-1 {{use @main instead}} {{1-19=@main}}
class MyDelegate : DelegateBase { }

Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
import AppKit

@NSApplicationMain // expected-error{{'NSApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class EvilDelegate: NSObject, NSApplicationDelegate {
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import AppKit

@NSApplicationMain // expected-error{{'NSApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, NSApplicationDelegate {
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,19 @@
import AppKit

@NSApplicationMain // expected-error{{'NSApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate1: NSObject, NSApplicationDelegate {
}

@NSApplicationMain // expected-error{{'NSApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate2: NSObject, NSApplicationDelegate {
}

@NSApplicationMain // expected-error{{'NSApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate3: NSObject, NSApplicationDelegate {
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@
import AppKit

@NSApplicationMain // expected-error{{'NSApplicationMain' class must conform to the 'NSApplicationDelegate' protocol}}
// expected-warning@-1 {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyNonDelegate {
}
10 changes: 10 additions & 0 deletions test/attr/ApplicationMain/attr_NSApplicationMain_swift6.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -swift-version 6 -typecheck -parse-as-library -verify %s

// REQUIRES: objc_interop

import AppKit

@NSApplicationMain // expected-error {{'NSApplicationMain' is deprecated}}
// expected-note@-1 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, NSApplicationDelegate {
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import AppKit

@NSApplicationMain // expected-error{{'NSApplicationMain' attribute cannot be used in a module that contains top-level code}}
// expected-warning@-1 {{'NSApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, NSApplicationDelegate {
}

Expand Down
3 changes: 2 additions & 1 deletion test/attr/ApplicationMain/attr_UIApplicationMain.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import UIKit

@UIApplicationMain
@UIApplicationMain // expected-warning {{'UIApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-1 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, UIApplicationDelegate {
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import UIKit

class DelegateBase : NSObject, UIApplicationDelegate { }

@UIApplicationMain
@UIApplicationMain // expected-warning {{'UIApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-1 {{use @main instead}} {{1-19=@main}}
class MyDelegate : DelegateBase { }

Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,19 @@
import UIKit

@UIApplicationMain // expected-error{{'UIApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'UIApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate1: NSObject, UIApplicationDelegate {
}

@UIApplicationMain // expected-error{{'UIApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'UIApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate2: NSObject, UIApplicationDelegate {
}

@UIApplicationMain // expected-error{{'UIApplicationMain' attribute can only apply to one class in a module}}
// expected-warning@-1 {{'UIApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate3: NSObject, UIApplicationDelegate {
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@
import UIKit

@UIApplicationMain // expected-error{{'UIApplicationMain' class must conform to the 'UIApplicationDelegate' protocol}}
// expected-warning@-1 {{'UIApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyNonDelegate {
}
10 changes: 10 additions & 0 deletions test/attr/ApplicationMain/attr_UIApplicationMain_swift6.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -swift-version 6 -typecheck -parse-as-library -verify %s

// REQUIRES: objc_interop

import UIKit

@UIApplicationMain // expected-error {{'UIApplicationMain' is deprecated}}
// expected-note@-1 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, UIApplicationDelegate {
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import UIKit

@UIApplicationMain // expected-error{{'UIApplicationMain' attribute cannot be used in a module that contains top-level code}}
// expected-warning@-1 {{'UIApplicationMain' is deprecated; this is an error in Swift 6}}
// expected-note@-2 {{use @main instead}} {{1-19=@main}}
class MyDelegate: NSObject, UIApplicationDelegate {
}

Expand Down