[WIP] if/switch expressions #62178
Closed
[WIP] if/switch expressions #62178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
express-yourself
branch
8 times, most recently
from
bec3769 to
338c133
Compare
hamishknight
force-pushed
the
express-yourself
branch
4 times, most recently
from
0a38b86 to
ace8db7
Compare
hamishknight
force-pushed
the
express-yourself
branch
4 times, most recently
from
42e0c61 to
a5ef8f8
Compare
hamishknight
force-pushed
the
express-yourself
branch
4 times, most recently
from
17f80b1 to
6c82031
Compare
hamishknight
force-pushed
the
express-yourself
branch
7 times, most recently
from
7b4f120 to
69c548b
Compare
hamishknight
force-pushed
the
express-yourself
branch
from
69c548b to
43419dd
Compare
hamishknight
force-pushed
the
express-yourself
branch
2 times, most recently
from
5a5af00 to
1813dbd
Compare
Missed this when I originally added the `--lit-jobs` build-script option, propagate the value provided to `LLVM_LIT_ARGS` in addition to `SWIFT_LIT_ARGS`.
Split out brace element handling for a couple of walkers into a new function. The diff for this is best viewed without whitespace changes. This should be NFC.
And change `getBody` to `getStmt` to reflect the fact that we always rewrite a statement.
Factor out some type-checking logic for ReturnStmt, including the conversion to FailStmt, into a request. We can then invoke this request from both the regular type-checking path, as well as during a pre-check of an expression.
hamishknight
force-pushed
the
express-yourself
branch
from
1813dbd to
9042424
Compare
|
swiftlang/swift-syntax#1096 @swift-ci please test source compatibility |
|
Continuing on #63022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS toolchain: https://ci.swift.org/job/swift-PR-toolchain-macos/494/artifact/branch-main/swift-PR-62178-494-osx.tar.gz
with last expression as the result: https://ci.swift.org/job/swift-PR-toolchain-macos/460/artifact/branch-main/swift-PR-62178-460-osx.tar.gz