Macro declarations #62204
Merged
Macro declarations #62204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
force-pushed
the
macro-declarations
branch
3 times, most recently
from
07b4018 to
5b3c24f
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
DougGregor
requested review from
ahoppen,
bnbarham,
CodaFi,
rintaro and
zoecarver
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
rxwei
reviewed
Nov 28, 2022
Comment on lines
22
to
23
| #include "swift/Demangling/Demangle.h" | ||
| #include "swift/Demangling/Demangler.h" |
There was a problem hiding this comment.
These are probably no longer needed.
There was a problem hiding this comment.
I'll do this in a follow-up PR, thanks.
| free(const_cast<void *>((const void *)returnedName.data())); | ||
| kind = invokeKind(); | ||
| } | ||
| if ((&swift_conformsToProtocol == nullptr) || !protocolDescriptor) |
There was a problem hiding this comment.
Isn't &swift_conformsToProtocol never null since it's either a local variable or an extern declaration? swift_conformsToProtocol could be null.
There was a problem hiding this comment.
Ah... yeah, I got sloppy here. I'll fix it in a follow-up.
DougGregor
force-pushed
the
macro-declarations
branch
from
123490e to
fa2ff3a
Compare
|
AARRGGGGHHHH silly conflict |
|
@swift-ci please smoke test |
Enable type checking support for explicitly specifying generic arguments to a macro, e.g., `#stringify<Double>(1 + 2)`. To do so, introduce a new kind of constraint that performs explicit argument matching against the generic parameters of a macro only after the overload is chosen.
…ion. A macro declaration contains the external module and type name of the macro's implementation. Use that information to find the macro type (via its type metadata accessor) in a loaded plugin, so we no longer require the "allMacros" array. Instead, each macro implementation type must be a public struct. Since we are now fully dependent on the macro declaration for everything about a macro except its kind, remove most of the query infrastructure for compiler plugins. Replace the macro registration scheme based on the allMacros array with
Don't look up the macro name again when doing expansion; that's already been done when we found the macro definition.
This approach works for both macros built into the compiler (e.g., the builtin macros) as well as those that are loaded via plugin but don't conform to the _CompilerPluginSupport protocol. This eliminates all uses of the `MacroSystem` itself in ASTGen, and pushes more of the implementation through ASTGen.
Although macro declarations never produce any symbols in the compiled binary, they can be referenced via USR, so introduce a mangling for them.
DougGregor
force-pushed
the
macro-declarations
branch
from
fa2ff3a to
64f2c8e
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce macro declarations and use them for the... declaration... of macros... with a way to specify the externally-provided definition of the macro. Macro declarations look like this:
With these macro declarations, we no longer need to query the macro implementation for the type signature, because it's all available in the source. Nor do we need
allMacrosto help us find macros, because the macro module and type name is specified in the definition.Macro declarations also make most of the other features one expects work easily, so wire up access control, code completion, and indexing in the process.