Fix warnings in main and rebranch #62217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids a conflict with clang's `ANALYSIS` macro. Fixes a macro redefinition warning.
add `value()` which replaces the deprecated `getValue()`
`getValue` -> `value` `getValueOr` -> `value_or` `hasValue` -> `has_value` `map` -> `transform` The old API will be deprecated in the rebranch. To avoid merge conflicts, use the new API already in the main branch. rdar://102362022
eeckstein
requested review from
zoecarver,
hyp,
egorzhdan,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci test |
eeckstein
removed request for
rintaro,
hyp,
DougGregor,
CodaFi,
egorzhdan,
ahoppen and
zoecarver
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Jan 25, 2023
This is a follow-up of swiftlang#62217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big part of this PR is to change to the new
llvm::OptionalAPI:getValue->valuegetValueOr->value_orhasValue->has_valuemap->transformThe old API will be deprecated in the
rebranch.To avoid merge conflicts, use the new API already in
main.rdar://102362022
The PR also contains some other fixes for warnings in main and rebranch. For details see the commit messages.