Skip to content

NFC: add code owner for Windows specifics #62222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2022
Merged

NFC: add code owner for Windows specifics #62222

merged 1 commit into from
Nov 28, 2022

Conversation

egorzhdan
Copy link
Contributor

No description provided.

@egorzhdan egorzhdan requested a review from compnerd November 22, 2022 14:06
compnerd
compnerd approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There definitely are other pieces which are Windows specific scattered throughout the code, but this is a good starting point.

@compnerd
Copy link
Member

@swift-ci please smoke test

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit 4bfe284 into main Nov 28, 2022
@egorzhdan egorzhdan deleted the egorzhdan/windows-codeowner branch November 28, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
contributor experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @compnerd