IRGen: fix and re-enable static read-only arrays #62226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
Catfish-Man
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Whoops, sorry, didn't see this until now. I think the bridging buffer stuff has some issues, but they're not new in this code, so we'll fix them whenever we fix the existing bits (I don't know what specifically is wrong, I just have some reports that suggest it may be).
Looks good in general!
eeckstein
force-pushed
the
read-only-static-arrays
branch
from
45c525a to
b73539a
Compare
eeckstein
force-pushed
the
read-only-static-arrays
branch
from
b73539a to
54ba147
Compare
eeckstein
requested review from
a team,
tshortli,
hborla,
slavapestov and
xedin
as code owners
glessard
reviewed
Dec 12, 2023
glessard
approved these changes
Dec 12, 2023
Azoy
reviewed
Dec 12, 2023
Static read-only arrays didn't work when passed to ObjectiveC as NSArray. The storage class of static read-only arrays doesn't carry information about the Element type. The new `__SwiftDeferredStaticNSArray` is generic over the element type and doesn't have to rely on the element type information of the array storage. rdar://94185998
eeckstein
force-pushed
the
read-only-static-arrays
branch
from
54ba147 to
e4ea749
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static read-only arrays didn't work when passed to ObjectiveC as NSArray. The storage class of static read-only arrays doesn't carry information about the Element type. The new
__SwiftDeferredStaticNSArrayis generic over the element type and doesn't have to rely on the element type information of the array storage.This is a follow-up of #59612
rdar://94185998