Add and improve some "mandatory" peephole optimization to fix a performance diagnostic #62247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ole optimization
…optimization In performance-annotated functions optimize the pattern where a partial_apply is immediately applied. This remove the partial apply and thus avoids an allocation. Fixes an unnecessary performance violation error. rdar://95155145
eeckstein
force-pushed
the
fix-perf-annotation-optimization
branch
from
14baf8b to
d80d7dd
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
begin_borrowwhen checking if apartial_applyescapes.begin_borrowin the partial_apply -> apply peephole optimizationFixes an unnecessary performance violation error.
rdar://95155145