docs: convert ErrorHandling from .rst to .md
#62297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves partially #49997.
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
Nov 29, 2022
|
I suspect the diff is all red because some functions in the snippets don’t have a closing brace. |
That's the behaviour of the tool that I use for conversion. Unfortunately, I'm not sure if it's customizable, and I'd prefer to stay on the safe side in case something actually has to be escaped. Backslashes before apostrophes and quotes have no effect on how those are rendered, so it seems safe to keep them. |
|
I see. I tend to be pedantic about this sort of benign though unnecessary noise, but I will leave this to the other reviewers’ discretion ✌🏻 |
CodaFi
reviewed
Nov 29, 2022
docs/ErrorHandling.md
Outdated
| Error handling is a well-trod path, with many different approaches in | ||
| other languages, many of them problematic in various ways. We believe | ||
| that our approach provides an elegant solution, drawing on the lessons | ||
| we\'ve learned from other languages and fixing or avoiding some of the |
CodaFi
reviewed
Nov 29, 2022
docs/ErrorHandling.md
Outdated
|
|
||
| ## Kinds of Error | ||
|
|
||
| What exactly is an \"error\"? There are many possible error conditions, |
MaxDesiatov
force-pushed
the
maxd/docs-error-handling
branch
from
ecc0039 to
beb846f
Compare
MaxDesiatov
force-pushed
the
maxd/docs-error-handling
branch
from
beb846f to
4296351
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves partially #49997.