ModuleInterface: Avoid printing @_spi enum elements in public swiftinterfaces
#62300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
commented
Nov 29, 2022
| @@ -1,29 +0,0 @@ | |||
| // Test limits of SPI members in frozen types. | |||
There was a problem hiding this comment.
This file was deleted because the tests it contains seem to be completely superseded by the spi_members.swift test.
tshortli
commented
Nov 29, 2022
| @@ -34,14 +34,6 @@ | |||
| // RUN: %target-swift-frontend -typecheck-module-from-interface -I %t %t/Main.swiftinterface | |||
| // RUN: %target-swift-frontend -typecheck-module-from-interface -I %t %t/Main.private.swiftinterface -module-name Main | |||
|
|
|||
| /// Serialize and deserialize this module, then print. | |||
There was a problem hiding this comment.
I removed this because it interfered with the stability of printing the interface with an enum case declaration like case a, b. It seemed safe to remove to me because there are many other tests exercising serialization and deserialization of the @_spi attribute simply by compiling a helper module with @_spi declarations. If this is still needed for some reason, though, I can split it into a new test case.
nkcsgexi
reviewed
Nov 29, 2022
…ftinterfaces. rdar://72873771
rdar://72873771
These tests identified a gap in type checking the exportability of case statements. Unfortunately this gap is not simple to close, since exportability is usually checked during availability checking but availability checking isn't appropriate for case statements and there isn't existing infrastructure to check exportability independently.
This utility helps codify the practice of using the attributes of the first element of a case decl as the attributes for the entire case.
tshortli
force-pushed
the
spi-enum-cases
branch
from
d8b5a43 to
85ddda1
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@_spiattribute was accepted on enum case declarations but the cases were still printed in public swiftinterfaces, leaking the SPI. The compiler now avoids printing enum cases in public swiftinterfaces when they are declared as@_spiby checking whether the enum case declaration contains any enum elements that are SPI (enum case declarations apparently do not themselves have a copy of the attributes they were written with). The compiler now also diagnoses@_spion enum case declarations when the enum is@frozensince all the cases of a frozen enum must be known to the client so that the memory layout for the enum can be computed.This PR also includes tests that show that the exportability of case statements is not checked. Unfortunately this gap is not simple to close since exportability is usually checked during availability checking but availability checking isn't appropriate for case statements and there isn't existing infrastructure to check exportability independently. A follow up PR will be needed to address this.
Resolves rdar://72873771