Skip to content

[SourceKit] Don't link 'sourcekitd' to service related code #62308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Nov 30, 2022

Separate 'sourcekitd/lib/API/Requests.cpp' to a library 'sourcekitdService' so the XPC client libary (i.e. sourcektid.framework/sourcekid) doesn't include unnecessary code.

rdar://102765542

@rintaro
Copy link
Member Author

rintaro commented Nov 30, 2022

@swift-ci Please smoke test

@rintaro rintaro requested a review from bnbarham November 30, 2022 00:50
Separate 'sourcekitd/lib/API/Requests.cpp' to a library
'sourcekitdService' so the XPC client libary (i.e.
sourcektid.framework/sourcekid) doesn't include unnecessary code.

rdar://102765542
@rintaro rintaro force-pushed the sourcekitd-rdar102765542 branch from c615aac to 0a791e8 Compare November 30, 2022 17:06
@rintaro
Copy link
Member Author

rintaro commented Nov 30, 2022

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Nov 30, 2022

@swift-ci Please smoke test Windows

@rintaro rintaro merged commit a28b92e into swiftlang:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants