[TypeLowering] Define "copy into" for opaque vals. #62322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new flag allows TypeLowering to be forced to behave as though -enable-sil-opaque-values was passed. That's needed in order to reasonably write tests on SIL which _notionally_ started out in opaque values mode and have since been address lowered.
When building with opaque values enable, types which would otherwise get AddressOnlyTypeLowering instead get OpaqueValueTypeLowering. When such types need to be copied into an address, the emitCopyInto method gets called on the OpaqueValueTypeLowering. So it must be implemented. Additionally, vary its implementation based on whether the module is address-lowered. If it's not address-lowered, emit a copy-into as if the type were loadable. If it is address-lowered, emit a copy-into as if the type were address-only.
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with opaque values enable, types which would otherwise get AddressOnlyTypeLowering instead get OpaqueValueTypeLowering. When such types need to be copied into an address, the emitCopyInto method gets called on the OpaqueValueTypeLowering. So it must be implemented.
Additionally, vary its implementation based on whether the module is address-lowered. If it's not address-lowered, emit a copy-into as if the type were loadable. If it is address-lowered, emit a copy-into as if the type were address-only.