Loop on Win32 to satisfy large random byte requests (as is done on Linux) #62364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
approved these changes
Dec 2, 2022
mikeash
approved these changes
Dec 2, 2022
|
@swift-ci please test |
compnerd
approved these changes
Dec 3, 2022
| fatalError(0, "Fatal error: %zd exceeds ULONG_MAX\n", nbytes); | ||
| } | ||
| while (nbytes > 0) { | ||
| auto actual_nbytes = std::min(nbytes, (__swift_size_t)ULONG_MAX); |
There was a problem hiding this comment.
It would be nice to use static_cast as this is C++.
Suggested change
| auto actual_nbytes = std::min(nbytes, (__swift_size_t)ULONG_MAX); | |
| auto actual_nbytes = std::min(nbytes, static_cast<__swift_size_t>(ULONG_MAX)); |
There was a problem hiding this comment.
@compnerd Can the #warning on line 64 be removed?
There was a problem hiding this comment.
Good question. AFAIK the unit tests for random number generation are not conditionalized by platform, are they?
There was a problem hiding this comment.
swift_stdlib_random is used in validation-test/stdlib/Random.swift, on all platforms AFAIK.
The #warning was originally an #error, because swift_stdlib_random was written without access to a compiler for Windows.
grynspan
force-pushed
the
jgrynspan/win32-random-large-size
branch
from
132cd3e to
9de9205
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves a crash on Windows when using
SystemRandomNumberGeneratorand requesting a very large number (>ULONG_MAX) of random bytes.In practice, it's unlikely anyone will be requesting more than 4GB of random bytes, but we don't abort on other platforms and nothing about the API suggests that a large buffer size is unsupported or disallowed.
I have not written a unit test because it would be impractical to request such a large amount of random data during a test run in CI.
Resolves #62130.