Skip to content

build: honour SWIFT_CLANG_LOCATION #62367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Dec 2, 2022

We would previously use clang-cl without the explicit path which could find an alternative clang-cl instance. This manifested as a failure to build libdispatch as part of the compiler when cross-compiling x64 to arm64.

We would previously use `clang-cl` without the explicit path which could
find an alternative `clang-cl` instance.  This manifested as a failure
to build libdispatch as part of the compiler when cross-compiling x64 to
arm64.
@compnerd
Copy link
Member Author

compnerd commented Dec 2, 2022

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Dec 2, 2022

CC: @drexin @etcwilde

Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit 70a148d into swiftlang:main Dec 2, 2022
@compnerd compnerd deleted the clang-cl branch December 2, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants