AddressLowering: speculative tightening of assertion #62385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows CI builds, we have observed a failure to build the Swift Standard Library after 10/27 (first noticed on 11/11 snapshot due to other failures). The failure is an invalid `isa` cast where the instance is a `nullptr`. The SILPipeline suggests that the SILOptimizer might be the one triggering the incorrect use of `isa`. The only instance of `isa` introduced in that range in the SILOptimizer/Mandatory region for that duration is this particular instance. Tighten the assertion to ensure that `oper->getUser()` returns a non-`nullptr` value. Thanks for @gwynne for helping narrow down the search area.
|
@swift-ci please test |
|
Yeah, this seems fine to me. The semantics don't change, but it makes it easier to debug without having to sift through a bunch of |
nate-chandler
approved these changes
Dec 3, 2022
|
Note that this pass is not yet being run when building the standard library. |
|
@nate-chandler interesting ... https://dev.azure.com/compnerd/swift-build/_build/results?buildId=60779&view=logs&j=dd7b6b62-9f28-5f94-8c40-5f429eddf697&t=44aa028c-6cf9-501c-b44f-94463714bfe5 is the build log. Perhaps something else stands out to you? |
|
Although this is really not the root cause of the current windows issue, I'm going to merge this as this can be helpful in the future. This ensures that we fail at the assertion rather than in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows CI builds, we have observed a failure to build the Swift Standard Library after 10/27 (first noticed on 11/11 snapshot due to other failures). The failure is an invalid
isacast where the instance is anullptr. The SILPipeline suggests that the SILOptimizer might be the one triggering the incorrect use ofisa. The only instance ofisaintroduced in that range in the SILOptimizer/Mandatory region for that duration is this particular instance. Tighten the assertion to ensure thatoper->getUser()returns a non-nullptrvalue.Thanks for @gwynne for helping narrow down the search area.