[Dependency Scanning] Simplify the persistent dependency scanning cache #62411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
BetterDependencyCaching-ContextHash
branch
3 times, most recently
from
914376d to
c92b456
Compare
|
@swift-ci test |
artemcm
force-pushed
the
BetterDependencyCaching-ContextHash
branch
from
c92b456 to
5bfa3b8
Compare
|
@swift-ci test |
…cache via context hash Introduces a concept of a dependency scanning action context hash, which is used to select an instance of a global dependency scanning cache which gets re-used across dependency scanning actions.
artemcm
force-pushed
the
BetterDependencyCaching-ContextHash
branch
from
5bfa3b8 to
951c5d3
Compare
|
@swift-ci test Linux Platform |
artemcm
force-pushed
the
BetterDependencyCaching-ContextHash
branch
from
951c5d3 to
a90dda5
Compare
|
@swift-ci test |
…che' by search path set This is no longer necessary since the cache is always configured for the current scanning context hash, which includes the search path set.
artemcm
force-pushed
the
BetterDependencyCaching-ContextHash
branch
from
a90dda5 to
f39c638
Compare
|
@swift-ci test |
|
@swift-ci test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key into a global (shared) dependency scanning cache via context hash.
Introduces a concept of a dependency scanning action context hash, which is used to select an instance of a global dependency scanning cache which gets re-used across multiple dependency scanning actions. In practice, this means that
GlobalModuleDependenciesCache's map is keyed with a Context Hash that a givenCompilerInvocationknows how to produce.Removes disambiguation of 'GlobalModuleDependenciesCache' results by search path set
Previously,
GlobalModuleDependenciesCachewas keyed by triple and returned a collection of results, one for each potential search path set. This is no longer necessary with the above change since the cache is always configured for the current scanning context hash, which includes the search path set.