[move-only-addr] Misc refactorings/cleanups #62423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a state structure with helpers. This just allows me to sink busy code into helpers on the state making the implementation easier to understand. It also gave me a good place to add comments that will make it clearer what we are actually doing. NFCI.
…ation into a helper method that returns a summary. Just refactoring further to make the code easier to understand. NFCI.
… a helper function. Just more refactoring in preparation for some fixes. NFCI.
…struct and clean it up a little bit to take summaries. NFCI.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a series of NFCI cleanups before I make larger changes. Just cleaned up the logic/deleted dead code/added comments/etc.