Serialization: Update -experimental-skip-non-inlinable-function-bodies SIL verification for @_backDeploy
#62427
Conversation
…es` SIL verification for `@_backDeploy`. SIL verification was failing for modules containing functions with `@_backDeploy` because `SILSkippingChecker` expected the `SILFunction` corresponding to the resilient copy of back deployed function to be empty. Since the overall function declaration for a back deployed function is considered inlinable, the body will be typechecked and SILGen emits both the fallback copy of the function and the resilient copy of the function. The checker should therefore expect to see back deployed functions that are not marked as serialized.
|
@swift-ci please test |
| // second resilient SILFunction is also emitted for back deployed functions. | ||
| // Since the body of the function as written was not skipped, it's expected | ||
| // that we see the SILFunction for the resilient copy here. | ||
| if (func->isBackDeployed()) |
There was a problem hiding this comment.
it seems a little bit odd for me that we need to check BackDeployed specifically here but not for other attributes like @_alwaysEmitIntoClient.
There was a problem hiding this comment.
@_backDeployed is special for the reasons described in the comment and in the PR description. Maybe there's a way I can describe this in a clearer way. @inlinable, AEIC, @_transparent are all handled by the if (F.isSerialized()) check at the top of this function. @_backDeployed causes two SILFunctions to be emitted. One of them passes the if (F.isSerialized()) check. The other (representing the resilient copy of the function) is the one we need to handle here.
There was a problem hiding this comment.
ah, makes sense. Thank you for the clarification!
tshortli
deleted the
back-deployed-attr-skip-noninlinable-function-bodies
branch
SIL verification was failing for modules built with
-experimental-skip-non-inlinable-function-bodiesand containing functions with@_backDeploybecauseSILSkippingCheckerexpected theSILFunctioncorresponding to the resilient copy of back deployed function to be empty. Since the overall function declaration for a back deployed function is considered inlinable, the body will be typechecked and SIL emitted. However, the checker should expect to see twoSILFunctions corresponding to each back deployed function: one for the client fallback copy (which passes the existingF.isSerialized()check) and a second representing the resilient copy of the function, which is not serialized. A specific exception is needed for that second function.