Update guaranteed forwarding phi apis and verification #62454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
guaranteedforwardingphiverify
branch
from
4bc29a9 to
9b57f51
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
guaranteedforwardingphiverify
branch
from
9b57f51 to
85e456b
Compare
|
@swift-ci test |
atrick
approved these changes
Dec 10, 2022
| return false; | ||
| // NOTE: canOpcodeForwardInnerGuaranteedValues returns true for transformation | ||
| // terminator results. | ||
| if (canOpcodeForwardInnerGuaranteedValues(value) || |
There was a problem hiding this comment.
I hope we can have a reborrow vs. forwarding flag on the phi soon so we don't need this distinction between "inner" guaranteed values and other guaranteed values! Then I don't think we need this logic.
| @@ -623,6 +625,38 @@ bool SILValueOwnershipChecker::isSubobjectProjectionWithLifetimeEndingUses( | |||
| }); | |||
| } | |||
|
|
|||
| bool SILValueOwnershipChecker:: | |||
There was a problem hiding this comment.
Thanks for this verification. If we had a reborrow phi flag, then then we wouldn't need any transitive verification at all.
Use OperandOwnership::GuaranteedForwarding instead.
…d forwarding operands on all paths
meg-gupta
force-pushed
the
guaranteedforwardingphiverify
branch
from
85e456b to
35d45de
Compare
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isGuaranteedForwardingPhiand updateisGuaranteedForwardingOperandOwnership::GuaranteedForwardingPhi, and update uses toOperandOwnership::GuaranteedForwarding