Skip to content

[AddressLowering] Handle store_borrow. #62486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 12, 2022

Conversation

nate-chandler
Copy link
Contributor

Thanks to the invariants of store_borrow, rewriting a store_borrow is a simple matter of replacing its (non end_borrow) uses with uses of the underlying address-only value whose use was stored.

@nate-chandler nate-chandler force-pushed the opaque-values/1/20221209 branch from 8a9b7c6 to 0f8240a Compare December 9, 2022 20:47
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Thanks to the invariants of store_borrow, rewriting a store_borrow is a
simple matter of replacing its (non end_borrow) uses with uses of the
underlying address-only value whose use was stored.
@nate-chandler nate-chandler force-pushed the opaque-values/1/20221209 branch from 0f8240a to 29067a5 Compare December 9, 2022 22:37
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nate-chandler nate-chandler marked this pull request as ready for review December 12, 2022 15:28
@nate-chandler nate-chandler merged commit fe49499 into swiftlang:main Dec 12, 2022
@nate-chandler nate-chandler deleted the opaque-values/1/20221209 branch December 12, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants