Skip to content

[OpaqueValues] Initial support for AD. #62494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Just enough to build _Differentiation.

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Just enough to build _Differentiation.
@nate-chandler nate-chandler force-pushed the opaque-values/2/20221209 branch from ce4c7f5 to c8bce4a Compare July 18, 2023 21:09
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler changed the title WIP [OpaqueValues] Initial support for AD. [OpaqueValues] Initial support for AD. Jul 18, 2023
@nate-chandler nate-chandler marked this pull request as ready for review July 18, 2023 22:11
@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

Source compatibility suite failures match failures in baseline.

@nate-chandler nate-chandler merged commit d13348c into swiftlang:main Jul 19, 2023
@nate-chandler nate-chandler deleted the opaque-values/2/20221209 branch July 19, 2023 14:12
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I'm not qualified to review the AD SILGen. But I'm glad you did this because the AD people were the ones who really wanted opaque values when they started... years ago. presumably it could simplify the representation

@rxwei
Copy link
Contributor

rxwei commented Jul 19, 2023

Oh thank you, we absolutely still want this!

cc @BradLarson @asl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants