SILOptimzer: correct a case of UB #62508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
changed the title
|
@swift-ci please test |
The current `UpdatingInstructionIteratorRegistry` referenced `this` in the member initializer list. As per class.cdtor 11.9.5p1, this is UB as for any class with a non-trivial constructor, referencing the base class of the object before the constructor begins execution is not permitted. We attempted to capture `this` in the lambda that was used to initialise the member. This was being exploited by the MSVC compiler resulting in incorrect execution of the instruction deleter.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
UpdatingInstructionIteratorRegistryreferencedthisinthe member initializer list. As per class.cdtor 11.9.5p1, this is UB as
for any class with a non-trivial constructor, referencing the base class
of the object before the constructor begins execution is not permitted.
We attempted to capture
thisin the lambda that was used to initialisethe member. This was being exploited by the MSVC compiler resulting in
incorrect execution of the instruction deleter.