[Concurrency] Fix missing inherit executor on withTaskCancellationHandler #62546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Hmmm but this is passing locally... maybe needs a clean |
|
@swift-ci please clean smoke test |
ktoso
force-pushed
the
wip-moreExecutorFixes
branch
from
a928379 to
5a97b0a
Compare
|
@swift-ci please clean test |
ktoso
added
the
concurrency
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Dec 16, 2022
ando-huang
pushed a commit
to ando-huang/swift
that referenced
this pull request
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar case to #62239 - i.e. another case of missing
@_unsafeInheritExecutoron a function which needed it.Also improve docs a bit while at it, explaining when onCancel triggers.
Resolves rdar://99845352