Skip to content

[interop][SwiftToCxx] support std::string -> Swift::String conversion… #62553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

[interop][SwiftToCxx] support std::string -> Swift::String conversion… #62553

merged 1 commit into from
Dec 14, 2022

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Dec 13, 2022

… in C++

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Dec 13, 2022
@hyp
Copy link
Contributor Author

hyp commented Dec 13, 2022

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Dec 13, 2022

@swift-ci please test source compatibility

egorzhdan
egorzhdan approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hyp hyp force-pushed the eng/string-fromstdtring branch from 8d12608 to f2c2cf5 Compare December 13, 2022 19:48
@hyp
Copy link
Contributor Author

hyp commented Dec 13, 2022

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Dec 13, 2022

@swift-ci please test source compatibility

hyp
hyp commented Dec 13, 2022
View reviewed changes
lib/PrintAsClang/ModuleContentsWriter.cpp
@@ -776,6 +776,10 @@ EmittedClangHeaderDependencyInfo swift::printModuleContentsAsCxx(
writer.write();
info.dependsOnStandardLibrary = writer.isStdlibRequired();
if (M.isStdlibModule()) {
// Embed additional STL includes.
os << "#ifndef SWIFT_CXX_INTEROP_HIDE_STL_OVERLAY\n";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robertorosmaninho

@hyp hyp force-pushed the eng/string-fromstdtring branch from f2c2cf5 to 5c703b4 Compare December 13, 2022 21:13
@hyp
Copy link
Contributor Author

hyp commented Dec 13, 2022

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Dec 13, 2022

@swift-ci please test source compatibility

@hyp hyp merged commit 7ce9778 into swiftlang:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @egorzhdan