[move-only-object] Teach move only object verifier how to emit proper errors for closure/defer uses #62567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic to improve QoI. Specifically, I want to add a special diagnostic for closure captures. By doing this as a separate commit it is easier to review/etc.
|
@swift-ci smoke test |
…opy. The current diagnostic that we are emitting is not perfect, but at least this prevents us from saying that an error is not occuring here. I am going to file a bug to track the QoI work of improving the diagnostic. rdar://103313305
gottesmm
force-pushed
the
pr-aff949c3a3e3aaf7839d4462bd96b8eb60c06f97
branch
from
5db3bd5 to
0735f9f
Compare
|
Found a small bug where I forgot that createStore with a managed value clones the cleanup of the passed in value. A bit of a footgun when using initializations. I added a test to make sure that we catch it in the test suite and not just when compiling code. |
|
@swift-ci smoke test |
|
Windows failed in LLVM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we error if one consumes a value at all in side a closure/defer and do not make a distinction in between no escape, defer, and escaping closures. This is just to make a sane base model that we can then build on top of.
rdar://103313305