[SourceKit] Only verify the solver-based cursor info implementation if requested #62576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/only-verify-cursor-info-if-requested
branch
from
909eea8 to
82fc482
Compare
|
@swift-ci Please smoke test |
4 similar comments
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
ahoppen/only-verify-cursor-info-if-requested
branch
from
82fc482 to
09803ed
Compare
|
@swift-ci Please smoke test |
…f requested This allows us to mark expected deviations between the AST-based and the solver-based implementation in the stress tester as XFails without breaking actual clients We always verify if a cursor info request is issued through `sourcekitd-test`.
ahoppen
force-pushed
the
ahoppen/only-verify-cursor-info-if-requested
branch
from
09803ed to
7811519
Compare
rintaro
approved these changes
Jan 31, 2023
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to mark expected deviations between the AST-based and the solver-based implementation in the stress tester as XFails without breaking actual clients
We always verify if a cursor info request is issued through
sourcekitd-test.swiftlang/swift-stress-tester#217 makes sure that we always verify the results in the SourceKit stress tester.