Macro diagnostics fixes #62598
Merged
Macro diagnostics fixes #62598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Relink" the folded syntax node back into the primary syntax node. When we do this, we get consistent source locations that do not require any adjustment. Test this by adding a Fix-It to the silly AddBlocker macro, replacing the `+` with a `-`.
|
@swift-ci please smoke test |
|
Huh... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up and fix the handling of source locations in diagnostics produced from macros, and test by adding a Fix-It to the AddBlocker macro that replaces the
+with a-. For diagnostics that come from a macro, append message text saying which macro it came from.