Skip to content

[Test] Disable stdlib/StaticBigInt on macOS #62621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Dec 15, 2022

No description provided.

@xymus xymus merged commit b46eb23 into swiftlang:main Dec 15, 2022
@xymus xymus deleted the test-staticbigint2 branch December 15, 2022 21:40
@tbkka
Copy link
Contributor

tbkka commented Dec 21, 2022

@xymus Is there a link to the test failure? Unlike #62594, this isn't obviously a test mis-configuration issue.

CC: @benrimmington @stephentyrone

@xymus
Copy link
Contributor Author

xymus commented Dec 21, 2022

I updated rdar://103369837 with links to failures under macosx-x86_64 and iphoneos-arm64. The disabling in this PR didn't take effect because I forgot the x in macosx.

@tbkka Do we have a fix in sight? Otherwise we may want to disable this test on 3 platforms.

@tbkka
Copy link
Contributor

tbkka commented Dec 21, 2022

The test failures we're seeing internally are all manifesting similar errors:

stderr>>> dyld: lazy symbol binding failed: Symbol not found: _$ss12StaticBigIntV22_builtinIntegerLiteralABBI_tcfC
stderr>>>   Referenced from: .../test-iphoneos-arm64/stdlib/Output/StaticBigInt.swift.tmp/a.out
stderr>>>   Expected in: /usr/lib/swift/libswiftCore.dylib

It looks like the tests need to be updated to only run when testing against a suitably new libswiftCore.dylib.

(Context: We run Swift test suites internally with the system-installed libswiftCore.dylib and with the just-built libswiftCore.dylib in order to detect issues that will affect binaries running on different OS versions. Features that don't support backwards deployment need to have their tests suitably guarded.)

@benrimmington
Copy link
Contributor

@tbkka For the macOS failure, would one (or both) of the following be needed?

// UNSUPPORTED: back_deployment_runtime
// UNSUPPORTED: use_os_stdlib

Or is there some other way to guard the tests?

@tbkka
Copy link
Contributor

tbkka commented Dec 21, 2022

UNSUPPORTED: use_os_stdlib is what we need for that macOS failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants