[move-only] Make sure that we convert copy_value/load [copy] move only to their after error variant if we error early. #62631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
…y to their after error variant if we error early. In sum, if we hit an early error that says that we found a situation that we don't know how to handle, we were not converting copy_value -> explicit_copy_value and load [copy] -> load_borrow + copy_value. Discovered this issue while attempting to enable sil-verify-all on the move only tests. Once I enable that on the relevant tests, this will be tested by sil-verify-all not triggering. I have a few other things to fix before I can do that though.
gottesmm
force-pushed
the
pr-d0e166cdd030c3826f8abfc0081e61545623320f
branch
from
90b6bac to
b80984c
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sum, if we hit an early error that says that we found a situation that we don't know how to handle, we were not converting copy_value -> explicit_copy_value and load [copy] -> load_borrow + copy_value.
Discovered this issue while attempting to enable sil-verify-all on the move only tests. Once I enable that on the relevant tests, this will be tested by sil-verify-all not triggering. I have a few other things to fix before I can do that though.