[Sema] Teach typeCheckASTNodeAtLoc to check StmtConditionElement #62637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type checking a StmtConditionElement is slightly different than type checking the VarDecl declared by it because it doesn’t complain about redeclaration like `if let myVar = myVar`. Thus, we need to handle it in `typeCheckASTNodeAtLoc`
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
xedin
approved these changes
Dec 19, 2022
rintaro
approved these changes
Dec 21, 2022
|
No performance impact on code completion as measured by the stress tester. |
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #62574 to test its impact on code completion individually.
Type checking a StmtConditionElement is slightly different than type checking the VarDecl declared by it because it doesn’t complain about redeclaration like
if let myVar = myVar. Thus, we need to handle it intypeCheckASTNodeAtLoc