Re-enable coverage_smoke.swift #6264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We disabled this test because it started failing on the incremental bots. However, I couldn't reproduce the failure locally with a clean build. Try to reproduce the failure by enabling the test and running it through CI. Context: The specific failure was the llvm-cov detected a malformed coverage mapping in the 'coverage_smoke' binary. While debugging the issue, I found that the problem is that a FilenameIndex is invalid (refer: readIntMax(FilenameIndex, TranslationUnitFilenames.size(), in llvm's CoverageMappingReader). This means that the swift compiler is somehow generating an invalid index, although I don't see how this is possible.
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci Please smoke test Linux platform |
|
No problems with the CI, so I think our best option is to re-enable the test and watch out for failures. It's bad that we don't know what the root cause of the original failure was, but I can't dig any deeper without a copy of the build products from a failing build. If the issue occurs again I'll know to make such a copy. For now, it's important that we re-enable end-to-end testing for swift coverage. |
vedantk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disabled this test because it started failing on the incremental
bots. However, I couldn't reproduce the failure locally with a clean
build. Try to reproduce the failure by enabling the test and running it
through CI.
Context: The specific failure was the llvm-cov detected a malformed
coverage mapping in the 'coverage_smoke' binary. While debugging the
issue, I found that the problem is that a FilenameIndex is invalid
(refer: readIntMax(FilenameIndex, TranslationUnitFilenames.size(), in
llvm's CoverageMappingReader). This means that the swift compiler is
somehow generating an invalid index, although I don't see how this is
possible.
rdar://29591622