[Gardening] fix looking odd logical expression mixing bool and enum #62677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
approved these changes
Jan 1, 2023
|
ping |
| @@ -400,8 +400,7 @@ void CanonicalizeOSSALifetime::extendLivenessThroughOverlappingAccess() { | |||
| findLastConsume = !destroys.contains(&inst); | |||
| continue; | |||
| } | |||
| // Stop at the latest use. An earlier end_access does not overlap. | |||
There was a problem hiding this comment.
Was the comment removed on purpose?
There was a problem hiding this comment.
It wasn't intentional. Restored comment.
valeriyvan
force-pushed
the
CanonicalizeOSSALifetime-enum
branch
from
96321f8 to
735faf9
Compare
valeriyvan
changed the title
AnthonyLatsis
added
code health
SILOptimizer
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix looking odd logical expression mixing bool and enum.