Skip to content

Add error checks for input package name #62707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

Add error checks for input package name #62707

merged 2 commits into from
Jan 5, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Dec 20, 2022

Validate the value to the -package-name flag against c99 identifier, stdlib name, and module name.
Resolves rdar://103531208

@elsh
Copy link
Contributor Author

elsh commented Dec 20, 2022

@swift-ci test

1 similar comment
@elsh
Copy link
Contributor Author

elsh commented Dec 20, 2022

@swift-ci test

artemcm
artemcm reviewed Dec 20, 2022
View reviewed changes
tshortli
tshortli approved these changes Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
nkcsgexi
nkcsgexi approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

elsh
elsh commented Dec 20, 2022
View reviewed changes
elsh
elsh commented Dec 20, 2022
View reviewed changes
@elsh
Copy link
Contributor Author

elsh commented Dec 20, 2022

@swift-ci test

@elsh
Add error checks for input package name
ecc2042 
Resolves rdar://103531208
@elsh
Copy link
Contributor Author

elsh commented Dec 22, 2022

@swift-ci test

@elsh
Copy link
Contributor Author

elsh commented Dec 22, 2022

swiftlang/llvm-project#5866
@swift-ci test

@elsh
Copy link
Contributor Author

elsh commented Dec 22, 2022

@swift-ci test macos

@elsh elsh merged commit f315e11 into main Jan 5, 2023
@elsh elsh deleted the es-pkg-err branch January 5, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@artemcm artemcm artemcm approved these changes

@tshortli tshortli tshortli approved these changes

@xymus xymus Awaiting requested review from xymus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elsh @nkcsgexi @artemcm @tshortli