[Variadic Generics] Change pack expansion types and expressions to use the repeat syntax.
#62766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
force-pushed
the
pack-expansion-syntax
branch
3 times, most recently
from
02c59b3 to
20ff52f
Compare
hborla
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro and
zoecarver
as code owners
|
@swift-ci please smoke test |
hborla
force-pushed
the
pack-expansion-syntax
branch
from
3a2c00c to
cac7fbe
Compare
|
@swift-ci please smoke test |
This wasn't used, and callers can instead use getExpandedPacks, which also includes TypeReprs.
archetypes from the enclosing context, the ASTVerifier can cleanup these environments in 'cleanup'.
…pack expansion expressions, and create them in the parser instead of during pre-checking in the constraint system.
pack expansion type reprs. Classic variadic parameters still use the postfix ellipsis syntax, and pack expansion types now use a prefix 'repeat' keyword.
…imental feature flag to preserve existing parser diagnostics until the feature is official.
Previously, pack expansion types of plain parameter packs whose reduced shape is another parameter pack (i.e. as a result of parallel pack expansion somewhere else in the signature) was previously incorrect. Fixing that "broke" the incorrect mangling in these tests.
…nsitive to binding order.
…zily in the constraint system.
hborla
force-pushed
the
pack-expansion-syntax
branch
from
cac7fbe to
6e28f99
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler side change corresponding to swiftlang/swift-syntax#1167
We're explaining patterned pack expansion as using repetition patterns. Given a concrete pack substitution, the pattern is repeated for each element in the substituted pack. This syntax expresses this idea directly using the
repeatkeyword, andeachcontextual keywords applied to pack references:This change replaces postfix ellipsis with a prefix
repeatkeyword for pack expansion types and expressions. This also introduces a syntactic distinction between pack expansion types and classic variadic parameter types.