stdlib: repair 32bit non-Darwin build for TypeLayout #62781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
glibc's `uintptr_t` and `uint64_t` are both `unsigned long int`, but `uint32_t` is `unsigned int`, so BitVector overloads cannot be resoled on 32-bit platforms by following compilation error: error: call to member function 'add' is ambiguous bv.add(heap_object_abi::SwiftSpareBitsMask); darwin 32-bit platforms use stdint types defined in SwiftStdint.h, so they are identical
kateinoigakukun
force-pushed
the
pr-1c50f837dff8c45e643bd7cc67d17b9ad80e3f43
branch
from
abb1148 to
76981b4
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc's
uintptr_tanduint64_tare bothunsigned long int, butuint32_tisunsigned int, so BitVector overloads cannot be resoled on 32-bit platforms by following compilation error:error: call to member function 'add' is ambiguous
bv.add(heap_object_abi::SwiftSpareBitsMask);
darwin 32-bit platforms use stdint types defined in SwiftStdint.h, so they are identical
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves #NNNNN, fix apple/llvm-project#MMMMM.