[stdlib] Expose index rounding entry points #62798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… views These simply expose the preexisting internal `_StringGuts.validate*Index` functions that indexing operations use to implicitly round indices down to the nearest valid index. (Or, in the case of the encoding views, the nearest scalar boundary.) Being able to do this as a standalone, explicit, efficient operation is crucial when implementing some `String` algorithms that need to work with arbitrary indices.
|
@swift-ci test |
glessard
reviewed
Jan 4, 2023
| @@ -1086,3 +1086,90 @@ suite.test("Substring.removeSubrange entire range") | |||
| expectTrue(b.isEmpty) | |||
| #endif | |||
| } | |||
|
|
|||
| if #available(SwiftStdlib 5.8, *) { | |||
There was a problem hiding this comment.
Minor quibble: ideally skipped tests should be visible as having been skipped in the output.
There was a problem hiding this comment.
Agreed. Sadly we don't have a good way to express that in the current language -- the only thing we could do is to add the availability check as a skip condition while also repeating it within the test body, which seems unreasonably complicated. 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These simply expose the preexisting algorithms that String views use to implicitly round indices down to the nearest valid index within the view. (Or, in the case of the encoding views, rounding down to the nearest scalar boundary.)
Being able to do this as a standalone, explicit, efficient operation is crucial when implementing some
Stringalgorithms that need to work with arbitrary string indices.This PR exposes these operations as unstable, underscored entry points. Ideally these would get upgraded to public API soon, but first I'd like to prove these have the right semantics by experimenting with using them in their underscored form.
rdar://101652714