[5.8][TypeChecker] Enable result builder AST transform by default #62809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 697dfba)
…tements Visiting of transformed `do` shouldn't run syntatic diagnostics because they are going to be performed by `visit` that called `visitDoStmt`. (cherry picked from commit 36a50c7)
…o retrieve contextual type rdar://94224692 (cherry picked from commit c03addb)
…syntactic elements that don't contain completion token (cherry picked from commit 3c90c89)
(cherry picked from commit 5292699)
(cherry picked from commit b01d21b)
With AST transform enabled by default most of the previously invalid declarations became valid (due to SE-0373 being implemented only for AST transform). (cherry picked from commit 1e6e6e9)
|
@swift-ci please test |
hborla
approved these changes
Jan 3, 2023
`transformedBody` is available only if the flag is set, so there is no reason to double-check it before application, the presence of the transformed body is evidence enough.
|
@swift-ci please test |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #62734
This PR:
ResultBuilderASTTransform)Resolves: rdar://89880662
Resolves: rdar://97388257
Resolves: rdar://95235303
Resolves: rdar://96343005
Resolves: rdar://91731420
Resolves: rdar://95977761
Resolves: rdar://80680636