Fix #61531: swift-symbolgraph-extract crashes when trying to emit the 'Swift' module #62825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emit the 'Swift' module fix a crash in symbol graph generation caused by an empty SmallVector access while expanding protocol compositions during conformance expansion for extension block symbols
QuietMisdreavus
approved these changes
Jan 4, 2023
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain macOS |
|
@swift-ci Please Build Toolchain macOS Platform |
3 similar comments
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci Please Build Toolchain macOS Platform |
|
Sorry for the noise, i was trying to get a toolchain built to test some other projects that were starting to get similar build failures in SymbolGraphGen. I was just able to confirm that a locally-built compiler resolved those issues as well, so i'm going to tag a radar (rdar://103322385) as i merge. Thanks so much! |
|
FINALLY thank u Max! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in symbol graph generation caused by an empty SmallVector access while expanding protocol compositions when expanding conformances for a symbol. It also expands the relevant test so that it actually covers the logic causing the crash.
The bug affected all targets that declare a protocol conformance in an extension, where the protocol is or inherits from a protocol composition, for example:
Resolves #61531