Skip to content

[Compile Time Constant Extraction] Update string literal JSON formatting #62836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

[Compile Time Constant Extraction] Update string literal JSON formatting #62836

merged 1 commit into from
Jan 6, 2023

Conversation

jPaolantonio
Copy link
Contributor

This PR removes quotes around extracted string literals while still properly escaping characters.

@jPaolantonio
Copy link
Contributor Author

@swift-ci test

artemcm
artemcm approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, thanks.

@jPaolantonio jPaolantonio force-pushed the const-extract-string-literal-formatting branch from 7e03ab0 to 93563ee Compare January 5, 2023 20:14
@jPaolantonio
Copy link
Contributor Author

@swift-ci test

@jPaolantonio jPaolantonio merged commit 4a29080 into swiftlang:main Jan 6, 2023
@jPaolantonio jPaolantonio deleted the const-extract-string-literal-formatting branch January 17, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@quinntaylor quinntaylor Awaiting requested review from quinntaylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jPaolantonio @artemcm