[5.8][Diagnostics] Relax contextual type presence from assertion to a check #62843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations `getContextualType` for a contextual type locator is going to return then empty type. This happens because e.g. optional-some patterns and patterns with incorrect type don't have a contextual type for initialization expression but use a conversion with contextual locator nevertheless to indicate the purpose. This doesn't affect non-ambiguity diagnostics because mismatches carry both `from` and `to` types. Resolves: rdar://problem/103739206 (cherry picked from commit eaf0532)
|
@swift-ci please test |
hborla
approved these changes
Jan 4, 2023
|
@swift-ci please test macOS platform |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #62791
In some situations
getContextualTypefor a contextual type locatoris going to return then empty type. This happens because e.g.
optional-some patterns and patterns with incorrect type don't have a
contextual type for initialization expression but use a conversion with
contextual locator nevertheless to indicate the purpose. This doesn't
affect non-ambiguity diagnostics because mismatches carry both
fromandtotypes.Resolves: rdar://problem/103739206
(cherry picked from commit eaf0532)