[IRGen] RuntimeMetadata: Reference type descriptors indirectly when required #62850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to the fact that IRGen has been switched to use `getTypeRef`.
|
@swift-ci please smoke test |
DougGregor
approved these changes
Jan 4, 2023
|
@swift-ci please build toolchain macOS platform |
…equired Type descriptors cannot always be referenced directly (i.e. when a type is declared in a different module), so let's use `getAddrOfLLVMVariableOrGOTEquivalent` facility that knows how to handle that correctly. Resolves: rdar://problem/103878515
xedin
force-pushed
the
fix-type-reference-for-runtime-metadata-entry
branch
from
60688e8 to
55a6b34
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please build toolchain macOS platform |
stmontgomery
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type descriptors cannot always be referenced directly (i.e. when
a type is declared in a different module), so let's use
getAddrOfLLVMVariableOrGOTEquivalentfacility that knows howto handle that correctly.
Resolves: rdar://problem/103878515