[OpaqueValues] Map-into-context back-deploy thunk results. #62857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a throwing function which returns a generic (this is the simplest example) is back deployed, it gets a back deploy thunk. This back deploy thunk calls one of two variations of the function, depending on availability, both which have the same signature and in particular both return a generic. The result type of that function signature is an unbound generic. Previously, that result type was used as is. Consequently the success blocks for the try_apply instructions in these thunks had arguments of unbound generic type. Here, that type is mapped into the context of the function being emitted. The thunks now have the appropriate bound generic type.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci Please Test Source Compatibility Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a throwing function which returns a generic (this is the simplest example) is back deployed, it gets a back deploy thunk. This back deploy thunk calls one of two variations of the function, depending on availability, both which have the same signature and in particular both return a generic. The result type of that function signature is an unbound generic.
Previously, that result type was used as is. Consequently the success blocks for the
try_applyinstructions in these thunks had arguments of unbound generic type.Here, that type is mapped into the context of the function being emitted. The thunks now have the appropriate bound generic type.