Skip to content

[OpaqueValues] Build objc thunk args with fn conv. #62858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Used the function convention to determine whether a SILParameterInfo is indirect when emitting objc thunk arguments.

Used the function convention to determine whether a SILParameterInfo is
indirect when emitting objc thunk arguments.
@nate-chandler nate-chandler force-pushed the opaque-values/2/20230104 branch from 389f8ee to 927758f Compare January 5, 2023 02:18
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler marked this pull request as ready for review January 6, 2023 00:07
@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci Please Test Source Compatibility Release

@nate-chandler nate-chandler merged commit 902f023 into swiftlang:main Jan 6, 2023
@nate-chandler nate-chandler deleted the opaque-values/2/20230104 branch January 6, 2023 15:08
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants