[Diagnostics] Emit generated code buffers into diagnostic files. #62861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the serialized diagnostics file format to also support providing the contents of source files, which can include a reference to the "original source range" whose text is conceptually replaced with the contents of the serialized diagnostics file, e.g., due to macro expansion.
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
When emitting generated source file buffers, we could end up reallocating the DenseMap that tracks file IDs while still holding a reference to it. Hilarity ensues. Stop that hilarity by taking a copy. Additionally, make sure we don't emit an invalid source range, and instead put in empty source locations.
File IDs have been expressed using a 10-bit fixed field. This limits us to 1023 different files in which we can emit diagnostics, where overflowing would simply crash. With the introduction of macros and their generated source buffers, we're much more likely to overflow. Switch to a 5-bit VBR field, which is slightly smaller for the common case where there are few files involving diagnositcs, and which also allows us to have up to 2^32-1 file IDs.
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the serialized diagnostics file format to also support providing the contents of source files, which can include a reference to the "original source range" whose text is conceptually replaced with the contents of the serialized diagnostics file, e.g., due to macro expansion.
Implements the Swift side of rdar://103900370