ComputeSideEffects: correct side effects for destroy_addr #62864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A destroy_addr also involves a read from the address. It's equivalent to a `%x = load [take]` and `destroy_value %x`. It's also a write, because the stored value is not available anymore after the destroy. Fixes a compiler crash in SILMem2Reg. rdar://103879105
…perands We already ignored side effects of debug_value with non-address operands. Now also do this for address operands.
|
@swift-ci test |
|
@swift-ci benchmark |
1 similar comment
|
@swift-ci benchmark |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A destroy_addr also involves a read from the address. It's equivalent to a
%x = load [take]anddestroy_value %x.It's also a write, because the stored value is not available anymore after the destroy.
Fixes a compiler crash in SILMem2Reg.
rdar://103879105
Also, ignore side effects of debug_value with address operands.