-
Notifications
You must be signed in to change notification settings - Fork 10.5k
include/swift/Basic: fix deprecation warnings #62868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci smoke test |
7b8dc37
to
7dfb3ea
Compare
@swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to worry about compatibility with older compilers? I think that __has_trivial_constructor
is older I believe, so we are going to reduce the compatibility matrix here.
85a5bab
to
a19fd21
Compare
Would conditionally enabling |
These are deprecation warnings ``` include/swift/Basic/type_traits.h:49:29: warning: builtin __has_trivial_constructor is deprecated; use __is_trivially_constructible instead [-Wdeprecated-builtins] static const bool value = __has_trivial_constructor(T); ^ include/swift/Basic/type_traits.h:61:29: warning: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Wdeprecated-builtins] static const bool value = __has_trivial_destructor(T); ^ 2 warnings generated. ```
a19fd21
to
e5ab9b4
Compare
@swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
These are deprecation warnings