[cxx-interop] NFC: Improve documentation comments #62869
Conversation
…rator` Clarify that calling `makeIterator` on a C++ sequence has `O(n)` complexity.
|
@swift-ci please smoke test |
| /// array. | ||
| /// | ||
| /// - Complexity: O(*n*), where *n* is the number of elements in the C++ | ||
| /// collection. | ||
| /// container. |
There was a problem hiding this comment.
Wondering if we should add a note (for all these APIs) saying "Note that copying each element of the array may not take constant time, if the type of the element is defined in C++".
There was a problem hiding this comment.
That's reasonable, I added a note about that, thanks.
| /// | ||
| /// This initializer copies each element of the C++ collection to a new Swift | ||
| /// This initializer copies each element of the C++ container to a new Swift | ||
| /// array. | ||
| /// |
There was a problem hiding this comment.
This comment "This initializer copies each element of the C++ container to a new Swift array." might be misinterpreted to mean the init is creating a new Swift Array internally. You could instead say "Initializes the array (or self) by copying every element of the C++ container".
|
Hey, I am new to this, but I want to learn and work to fix. Can I get a explanation of what to do? |
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-sequence-docs
branch
from
bddedda to
2ac5ccf
Compare
|
@swift-ci please smoke test |
No description provided.