Fix DCE of begin_borrow with @guaranteed operand #62881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the lower most begin_borrows with @guaranteed operands, there was no @guaranteed phi computation, restructure the code and fix this case.
|
@swift-ci smoke test |
atrick
approved these changes
Jan 7, 2023
meg-gupta
commented
Jan 7, 2023
| }); | ||
| }; | ||
| // If we have a begin_borrow of a @guaranteed operand, disable DCE'ing | ||
| // of parent borrow scopes. Dead reborrows needs complex handling, whuch |
There was a problem hiding this comment.
TODO: Piggyback the typo in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the lower most begin_borrows with @guaranteed operands, there was no @guaranteed phi dependency computation, restructure the code and fix this case.