Teach DeclContext::getParentSourceFile() to return the innermost source file #62911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce file With macro expansions, and really any code generation that produces proper source locations, the parent source file of a declaration context will be a generated source file rather than the source file near the top of the declaration-context stack. Adjust the implementation of `getParentSourceFile()` to return that innermost source file by doing location-based lookup.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
The Windows failure is unrelated. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With macro expansions, and really any code generation that produces proper source locations, the parent source file of a declaration context will be a generated source file rather than the source file near the top of the declaration-context stack. Adjust the implementation of
getParentSourceFile()to return that innermost source file by doing location-based lookup.Fixes #62908